hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andras Bokor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10430) Refactor FileSystem#checkAccessPermissions for better reuse from tests
Date Fri, 20 May 2016 13:22:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15293342#comment-15293342
] 

Andras Bokor commented on HDFS-10430:
-------------------------------------

I got your point.
As far as I understand the {{InterfaceAudinece}} annotation is to inform callers if the method/class
can/should be used from outside of the project.
If we add a public counterpart syntactically we do not break the {{InterfaceAudience}} rules
but semantically we call a {{InterfaceAudience.Private}} method.
Please check HDFS-6570. As far as I understand {{FileSystem#checkAccessPermissions}} was made
private due to some security issues.
Even if we add counterpart to a class we should consider using @VisibleForTesting annotation.

> Refactor FileSystem#checkAccessPermissions for better reuse from tests
> ----------------------------------------------------------------------
>
>                 Key: HDFS-10430
>                 URL: https://issues.apache.org/jira/browse/HDFS-10430
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>
> FileSystem#checkAccessPermissions could be used in a bunch of tests from different projects,
but it's in hadoop-common, which is not visible in some cases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message