hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10415) TestDistributedFileSystem#testDFSCloseOrdering() fails on branch-2
Date Wed, 18 May 2016 16:58:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289312#comment-15289312
] 

Colin Patrick McCabe commented on HDFS-10415:
---------------------------------------------

Thanks for looking at this.

So basically the problem is that we're attempting to do something in the constructor of our
{{DistributedFileSystem}} subclass that requires that the FS already be initialized.  Why
not just override the {{initialize}} method with something like:

{code}
public void initialize() {
  super.initialize();
  statistics = new FileSystem.Statistics("myhdfs"); // can't mock finals
}
{code}

That seems like the most natural fix since it's not doing "weird stuff" that we don't do outside
unit tests.

I don't feel strongly about this, though, any of the solutions proposed here seems like it
would work.

> TestDistributedFileSystem#testDFSCloseOrdering() fails on branch-2
> ------------------------------------------------------------------
>
>                 Key: HDFS-10415
>                 URL: https://issues.apache.org/jira/browse/HDFS-10415
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.9.0
>         Environment: jenkins
>            Reporter: Sangjin Lee
>            Assignee: Mingliang Liu
>         Attachments: HDFS-10415-branch-2.000.patch, HDFS-10415-branch-2.001.patch, HDFS-10415.000.patch
>
>
> {noformat}
> Tests run: 24, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 51.096 sec <<<
FAILURE! - in org.apache.hadoop.hdfs.TestDistributedFileSystem
> testDFSCloseOrdering(org.apache.hadoop.hdfs.TestDistributedFileSystem)  Time elapsed:
0.045 sec  <<< ERROR!
> java.lang.NullPointerException: null
> 	at org.apache.hadoop.hdfs.DistributedFileSystem.delete(DistributedFileSystem.java:790)
> 	at org.apache.hadoop.fs.FileSystem.processDeleteOnExit(FileSystem.java:1417)
> 	at org.apache.hadoop.fs.FileSystem.close(FileSystem.java:2084)
> 	at org.apache.hadoop.hdfs.DistributedFileSystem.close(DistributedFileSystem.java:1187)
> 	at org.apache.hadoop.hdfs.TestDistributedFileSystem.testDFSCloseOrdering(TestDistributedFileSystem.java:217)
> {noformat}
> This is with Java 8 on Mac. It passes fine on trunk. I haven't tried other combinations.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message