hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rushabh S Shah (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10388) DistributedFileSystem#getStatus returns a misleading FsStatus
Date Wed, 11 May 2016 16:37:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280391#comment-15280391
] 

Rushabh S Shah commented on HDFS-10388:
---------------------------------------

This patch will break {{hdfs dfs -df /}} command.
Since {{Df#processPath(PathData item)}} will call {{DistributedFileSystem#getStatus()}} which
in turn will call {{dfs.getDiskStatus()}}.
Correct me if I am wrong.

> DistributedFileSystem#getStatus returns a misleading FsStatus
> -------------------------------------------------------------
>
>                 Key: HDFS-10388
>                 URL: https://issues.apache.org/jira/browse/HDFS-10388
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 2.7.1
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>         Attachments: HDFS-10388.001.patch
>
>
> The method {{DistributedFileSystem#getStatus}} returns the dfs's disk status.
> {code}
>    public FsStatus getStatus(Path p) throws IOException {
>      statistics.incrementReadOps(1);
>     return dfs.getDiskStatus();
>    }
> {code}
> So the param path is no meaning here. And the object returned will mislead for users
to use this method. I looked into the code, only when the file system has multiple partitions,
the use and capacity of the partition pointed to by the specified path will be reflected.
For example, in the subclass {{RawLocalFileSystem}}, it will be return correctly.
> We should return a new meaningless FsStatus here (like new FsStatus(0, 0, 0)) and indicate
that the invoked method isn't available in {{DistributedFileSystem}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message