hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Bovy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10257) Quick Thread Local Storage set-up has a small flaw
Date Mon, 16 May 2016 18:26:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285003#comment-15285003
] 

Stephen Bovy commented on HDFS-10257:
-------------------------------------

 

So I tried using   >>     cmake    .    <<<<<

 

And I got  >>  You must set the CMake variable GENERATED_JAVAH

 

So how to is use cmake on a stand-alone basis   (without maven)  to build libhdfs 

 

I guess I need a shell  script for set-up purposes ???   What do I need to set   ??    

 

It should not be that difficult 

 

 

[root@sandbox src]# cmake .

-- The C compiler identification is GNU 4.4.7

-- The CXX compiler identification is GNU 4.4.7

-- Check for working C compiler: /usr/bin/cc

-- Check for working C compiler: /usr/bin/cc -- works

-- Detecting C compiler ABI info

-- Detecting C compiler ABI info - done

-- Check for working CXX compiler: /usr/bin/c++

-- Check for working CXX compiler: /usr/bin/c++ -- works

-- Detecting CXX compiler ABI info

-- Detecting CXX compiler ABI info - done

JAVA_HOME=, JAVA_JVM_LIBRARY=/usr/lib/jvm/java/jre/lib/amd64/server/libjvm.so

JAVA_INCLUDE_PATH=/usr/lib/jvm/java/include, JAVA_INCLUDE_PATH2=/usr/lib/jvm/java/include/linux

Located all JNI components successfully.

-- Performing Test HAVE_BETTER_TLS

-- Performing Test HAVE_BETTER_TLS - Success

-- Performing Test HAVE_INTEL_SSE_INTRINSICS

-- Performing Test HAVE_INTEL_SSE_INTRINSICS - Success

-- Looking for dlopen in dl

-- Looking for dlopen in dl - found

-- Found JNI: /usr/lib/jvm/java/jre/lib/amd64/libjawt.so  

 

CMake Error at CMakeLists.txt:84 (MESSAGE):

  You must set the CMake variable GENERATED_JAVAH

 

 

 

-- Configuring incomplete, errors occurred!

See also "/root/hadoop-2.7.2-src/hadoop-hdfs-project/hadoop-hdfs/src/CMakeFiles/CMakeOutput.log".

[root@sandbox src]#

 



> Quick Thread Local Storage set-up has a small flaw
> --------------------------------------------------
>
>                 Key: HDFS-10257
>                 URL: https://issues.apache.org/jira/browse/HDFS-10257
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: libhdfs
>    Affects Versions: 2.6.4
>         Environment: Linux 
>            Reporter: Stephen Bovy
>            Priority: Minor
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> In   jni_helper.c   in the   getJNIEnv    function 
> The     “THREAD_LOCAL_STORAGE_SET_QUICK(env);”   Macro   is   in the  wrong location;
  
> It should precede   the  “threadLocalStorageSet(env)”   as follows ::  
>     THREAD_LOCAL_STORAGE_SET_QUICK(env);
>     if (threadLocalStorageSet(env)) {
>       return NULL;
>     }
> AND IN   “thread_local_storage.h”   the macro:   “THREAD_LOCAL_STORAGE_SET_QUICK”
> should be as follows :: 
> #ifdef HAVE_BETTER_TLS
>   #define THREAD_LOCAL_STORAGE_GET_QUICK() \
>     static __thread JNIEnv *quickTlsEnv = NULL; \
>     { \
>       if (quickTlsEnv) { \
>         return quickTlsEnv; \
>       } \
>     }
>   #define THREAD_LOCAL_STORAGE_SET_QUICK(env) \
>     { \
>       quickTlsEnv = (env); \
>       return env;
>     }
> #else
>   #define THREAD_LOCAL_STORAGE_GET_QUICK()
>   #define THREAD_LOCAL_STORAGE_SET_QUICK(env)
> #endif



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message