hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yongjun Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9732) Remove DelegationTokenIdentifier.toString() —for better logging output
Date Wed, 04 May 2016 20:26:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271380#comment-15271380

Yongjun Zhang commented on HDFS-9732:

HI [~aw],

Thanks for bringing dtutil to my attention, which seems to be a very recent addition to the
system. I saw that it does 
       AbstractDelegationTokenIdentifier id =
            (AbstractDelegationTokenIdentifier) token.decodeIdentifier();
        out.printf(fmt, token.getKind(), token.getService(),
                   (id != null) ? id.getRenewer() : NA_STRING,
                   (id != null) ? formatDate(id.getMaxDate()) : NA_STRING,
that defines its own format and doesn't use the {{toString()}} method. So the change I made
in HDFS-9732 won't have impact to dtutil unless I missed something.

Do you agree?


> Remove DelegationTokenIdentifier.toString() —for better logging output
> ----------------------------------------------------------------------
>                 Key: HDFS-9732
>                 URL: https://issues.apache.org/jira/browse/HDFS-9732
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.7.2
>            Reporter: Steve Loughran
>            Assignee: Yongjun Zhang
>         Attachments: HADOOP-12752-001.patch, HDFS-9732-000.patch, HDFS-9732.001.patch,
HDFS-9732.002.patch, HDFS-9732.003.patch, HDFS-9732.004.patch
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
> HDFS {{DelegationTokenIdentifier.toString()}} adds some diagnostics info, owner, sequence
number. But its superclass,  {{AbstractDelegationTokenIdentifier}} contains a lot more information,
including token issue and expiry times.
> Because  {{DelegationTokenIdentifier.toString()}} doesn't include this data,
> information that is potentially useful for kerberos diagnostics is lost.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message