hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yongjun Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9732) Remove DelegationTokenIdentifier.toString() —for better logging output
Date Tue, 03 May 2016 17:38:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269156#comment-15269156
] 

Yongjun Zhang commented on HDFS-9732:
-------------------------------------

Hi [~liuml07],

Thanks for your question. Please see some discussion here
http://stackoverflow.com/questions/4648607/stringbuilder-stringbuffer-vs-operator

For things that compiler will automatically translate from {{+}} to {{StringBuilder}}, we
probably don't have to change.  However, the change doesn't really hurt, and because of the
formatting done with the patch, readability looks better than original code rather than an
issue.

Some changes made in the patch is used in a loop to construct a string, where {{StringBuilder}}
is preferred.

Thanks.


> Remove DelegationTokenIdentifier.toString() —for better logging output
> ----------------------------------------------------------------------
>
>                 Key: HDFS-9732
>                 URL: https://issues.apache.org/jira/browse/HDFS-9732
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.7.2
>            Reporter: Steve Loughran
>            Assignee: Yongjun Zhang
>         Attachments: HADOOP-12752-001.patch, HDFS-9732-000.patch, HDFS-9732.001.patch,
HDFS-9732.002.patch, HDFS-9732.003.patch, HDFS-9732.004.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> HDFS {{DelegationTokenIdentifier.toString()}} adds some diagnostics info, owner, sequence
number. But its superclass,  {{AbstractDelegationTokenIdentifier}} contains a lot more information,
including token issue and expiry times.
> Because  {{DelegationTokenIdentifier.toString()}} doesn't include this data,
> information that is potentially useful for kerberos diagnostics is lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message