Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1246E19046 for ; Tue, 19 Apr 2016 01:17:26 +0000 (UTC) Received: (qmail 24083 invoked by uid 500); 19 Apr 2016 01:17:25 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 24019 invoked by uid 500); 19 Apr 2016 01:17:25 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 23905 invoked by uid 99); 19 Apr 2016 01:17:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Apr 2016 01:17:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 994432C1F68 for ; Tue, 19 Apr 2016 01:17:25 +0000 (UTC) Date: Tue, 19 Apr 2016 01:17:25 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-10306) SafeModeMonitor should not leave safe mode if name system is starting active service MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15246905#comment-15246905 ] Hudson commented on HDFS-10306: ------------------------------- FAILURE: Integrated in Hadoop-trunk-Commit #9629 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/9629/]) HDFS-10306. SafeModeMonitor should not leave safe mode if name system is (jing9: rev be0bce1b7171c49e2dca22f56d4e750e606862fc) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManagerSafeMode.java > SafeModeMonitor should not leave safe mode if name system is starting active service > ------------------------------------------------------------------------------------ > > Key: HDFS-10306 > URL: https://issues.apache.org/jira/browse/HDFS-10306 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Reporter: Mingliang Liu > Assignee: Mingliang Liu > Fix For: 2.9.0 > > Attachments: HDFS-10306.000.patch > > > This is a follow-up of [HDFS-10192]. > The {{BlockManagerSafeMode$SafeModeMonitor#canLeave()}} is not checking the {{namesystem#inTransitionToActive()}}, while it should. According to the fix of [HDFS-10192], we should add this check to prevent the {{smmthread}} from calling {{leaveSafeMode()}} too early. -- This message was sent by Atlassian JIRA (v6.3.4#6332)