Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BF08519DFF for ; Tue, 26 Apr 2016 10:02:14 +0000 (UTC) Received: (qmail 28449 invoked by uid 500); 26 Apr 2016 10:02:13 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 28345 invoked by uid 500); 26 Apr 2016 10:02:13 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 28307 invoked by uid 99); 26 Apr 2016 10:02:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Apr 2016 10:02:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 1FA522C1F62 for ; Tue, 26 Apr 2016 10:02:13 +0000 (UTC) Date: Tue, 26 Apr 2016 10:02:13 +0000 (UTC) From: "Wei-Chiu Chuang (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-10260) TestFsDatasetImpl#testCleanShutdownOfVolume often fails MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257845#comment-15257845 ] Wei-Chiu Chuang commented on HDFS-10260: ---------------------------------------- looks good to me. Thanks for the contribution. > TestFsDatasetImpl#testCleanShutdownOfVolume often fails > ------------------------------------------------------- > > Key: HDFS-10260 > URL: https://issues.apache.org/jira/browse/HDFS-10260 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode, test > Reporter: Wei-Chiu Chuang > Assignee: Rushabh S Shah > Attachments: HDFS-10260-v1.patch, HDFS-10260.patch > > > This test failure occurs in upstream Jenkins. Looking at the test code, I think it should be improved to capture the root cause of failure: > E.g. change {{Thread.sleep(1000)}} to {{GenericTestUtils.waitFor}} and use {{GenericTestUtils.assertExceptionContains}} to replace > {code} > Assert.assertTrue(ioe.getMessage().contains(info.toString())); > {code} > https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/1062/testReport/junit/org.apache.hadoop.hdfs.server.datanode.fsdataset.impl/TestFsDatasetImpl/testCleanShutdownOfVolume/ > java.lang.AssertionError: null > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertTrue(Assert.java:52) > at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl.testCleanShutdownOfVolume(TestFsDatasetImpl.java:683) > Standard Error > Exception in thread "DataNode: [[[DISK]file:/home/jenkins/jenkins-slave/workspace/Hadoop-Hdfs-trunk-Java8/hadoop-hdfs-project/hadoop-hdfs/target/test/data/dfs/data/data1/, [DISK]file:/home/jenkins/jenkins-slave/workspace/Hadoop-Hdfs-trunk-Java8/hadoop-hdfs-project/hadoop-hdfs/target/test/data/dfs/data/data2/]] heartbeating to localhost/127.0.0.1:35113" java.lang.NullPointerException > at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.getBlockReports(FsDatasetImpl.java:1714) > at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.shutdownBlockPool(FsDatasetImpl.java:2591) > at org.apache.hadoop.hdfs.server.datanode.DataNode.shutdownBlockPool(DataNode.java:1479) > at org.apache.hadoop.hdfs.server.datanode.BPOfferService.shutdownActor(BPOfferService.java:411) > at org.apache.hadoop.hdfs.server.datanode.BPServiceActor.cleanUp(BPServiceActor.java:494) > at org.apache.hadoop.hdfs.server.datanode.BPServiceActor.run(BPServiceActor.java:749) > at java.lang.Thread.run(Thread.java:744) -- This message was sent by Atlassian JIRA (v6.3.4#6332)