Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 20D4F18F66 for ; Mon, 4 Apr 2016 12:38:26 +0000 (UTC) Received: (qmail 27506 invoked by uid 500); 4 Apr 2016 12:38:25 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 27445 invoked by uid 500); 4 Apr 2016 12:38:25 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 27434 invoked by uid 99); 4 Apr 2016 12:38:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Apr 2016 12:38:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 6DB682C1F58 for ; Mon, 4 Apr 2016 12:38:25 +0000 (UTC) Date: Mon, 4 Apr 2016 12:38:25 +0000 (UTC) From: "Brahma Reddy Battula (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-10245) Fix the findbug warnings in branch-2.7 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224037#comment-15224037 ] Brahma Reddy Battula commented on HDFS-10245: --------------------------------------------- Hi [~aw] *Seems to be, findbug report shows {{branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html}} {color:blue}instead of{color} {{patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html}}* *After Patch shows "0" warnings. which is not considered for QA* {noformat} ============================================================================ ============================================================================ Patch findbugs detection ============================================================================ ============================================================================ cd /testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hadoop-branch-2.7-0 -Ptest-patch -DskipTests test-compile findbugs:findbugs -DskipTests=true > /testptch/hadoop/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt 2>&1 Elapsed: 3m 1s Starting with /testptch/hadoop/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.xml Merging /testptch/hadoop/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.xml Writing /testptch/hadoop/patchprocess/combined-findbugs-hadoop-hdfs-project_hadoop-hdfs.xml hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) {noformat} *Pre-patch shows "1" warning, same reported in QA.* {noformat} ============================================================================ ============================================================================ Pre-patch findbugs detection ============================================================================ ============================================================================ cd /testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hadoop-branch-2.7-0 -Ptest-patch -DskipTests test-compile findbugs:findbugs -DskipTests=true > /testptch/hadoop/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt 2>&1 Elapsed: 2m 50s hadoop-hdfs-project/hadoop-hdfs in branch-2.7 has 1 extant Findbugs warnings. {noformat} > Fix the findbug warnings in branch-2.7 > -------------------------------------- > > Key: HDFS-10245 > URL: https://issues.apache.org/jira/browse/HDFS-10245 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 2.7.2 > Reporter: Brahma Reddy Battula > Assignee: Brahma Reddy Battula > Attachments: HDFS-10245-branch-2.7.patch > > > *Link* > https://builds.apache.org/job/PreCommit-HDFS-Build/15036/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html > Following seen in HDFS-9917 jenkins run. > {noformat} > Code Warning > IS Inconsistent synchronization of org.apache.hadoop.hdfs.DFSOutputStream.streamer; locked 85% of time > Bug type IS2_INCONSISTENT_SYNC (click for details) > In class org.apache.hadoop.hdfs.DFSOutputStream > Field org.apache.hadoop.hdfs.DFSOutputStream.streamer > Synchronized 85% of the time > Unsynchronized access at DFSOutputStream.java:[line 2372] > Unsynchronized access at DFSOutputStream.java:[line 2390] > Unsynchronized access at DFSOutputStream.java:[line 1722] > Synchronized access at DFSOutputStream.java:[line 2178] > Synchronized access at DFSOutputStream.java:[line 2100] > Synchronized access at DFSOutputStream.java:[line 2103] > Synchronized access at DFSOutputStream.java:[line 2264] > Synchronized access at DFSOutputStream.java:[line 1555] > Synchronized access at DFSOutputStream.java:[line 1558] > Synchronized access at DFSOutputStream.java:[line 2166] > Synchronized access at DFSOutputStream.java:[line 2208] > Synchronized access at DFSOutputStream.java:[line 2216] > Synchronized access at DFSOutputStream.java:[line 2209] > Synchronized access at DFSOutputStream.java:[line 2216] > Synchronized access at DFSOutputStream.java:[line 2037] > Synchronized access at DFSOutputStream.java:[line 2037] > Synchronized access at DFSOutputStream.java:[line 2038] > Synchronized access at DFSOutputStream.java:[line 2062] > Synchronized access at DFSOutputStream.java:[line 2063] > Synchronized access at DFSOutputStream.java:[line 2355] > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)