Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9241E1956C for ; Fri, 22 Apr 2016 18:52:15 +0000 (UTC) Received: (qmail 97915 invoked by uid 500); 22 Apr 2016 18:52:13 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 97819 invoked by uid 500); 22 Apr 2016 18:52:13 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 97491 invoked by uid 99); 22 Apr 2016 18:52:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Apr 2016 18:52:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 2115F2C1F73 for ; Fri, 22 Apr 2016 18:52:13 +0000 (UTC) Date: Fri, 22 Apr 2016 18:52:13 +0000 (UTC) From: "Tsz Wo Nicholas Sze (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-10224) Implement asynchronous rename for DistributedFileSystem MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254463#comment-15254463 ] Tsz Wo Nicholas Sze commented on HDFS-10224: -------------------------------------------- Thanks for the new patch. It looks good in general. Some comments: - In AsyncDistributedFileSystem, catch (Exception e) and catch (UnresolvedLinkException e) are not needed. - In DistributedFileSystem, getAsyncDistributedFileSystem() should not create a new object each time. It should just return the same object. Also, let's annotate getAsyncDistributedFileSystem() as @Unstable. I.e. {code} private final AsyncDistributedFileSystem adfs = new AsyncDistributedFileSystem(this); /** @return an {@link AsyncDistributedFileSystem} object. */ @Unstable public AsyncDistributedFileSystem getAsyncDistributedFileSystem() { return adfs; } {code} > Implement asynchronous rename for DistributedFileSystem > ------------------------------------------------------- > > Key: HDFS-10224 > URL: https://issues.apache.org/jira/browse/HDFS-10224 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: fs > Reporter: Xiaobing Zhou > Assignee: Xiaobing Zhou > Attachments: HDFS-10224-HDFS-9924.000.patch, HDFS-10224-HDFS-9924.001.patch, HDFS-10224-HDFS-9924.002.patch, HDFS-10224-HDFS-9924.003.patch, HDFS-10224-HDFS-9924.004.patch, HDFS-10224-and-HADOOP-12909.000.patch > > > This is proposed to implement an asynchronous DistributedFileSystem based on AsyncFileSystem APIs in HADOOP-12910. In addition, rename is implemented in this JIRA. -- This message was sent by Atlassian JIRA (v6.3.4#6332)