Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6ABEB19901 for ; Fri, 22 Apr 2016 19:55:13 +0000 (UTC) Received: (qmail 17179 invoked by uid 500); 22 Apr 2016 19:55:13 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 17125 invoked by uid 500); 22 Apr 2016 19:55:13 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 17107 invoked by uid 99); 22 Apr 2016 19:55:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Apr 2016 19:55:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 03D482C1F5A for ; Fri, 22 Apr 2016 19:55:13 +0000 (UTC) Date: Fri, 22 Apr 2016 19:55:13 +0000 (UTC) From: "Arpit Agarwal (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-9943) Support reconfiguring namenode replication confs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-9943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254545#comment-15254545 ] Arpit Agarwal commented on HDFS-9943: ------------------------------------- Thanks for the patch [~xiaobingo]. # reconfReplicationMultiplier - this function doesn't seem to be doing anything with the new Value. # getParamEffectiveVal - Let's rename this to getParameterEffectiveValue and please add javadoc. We may be overusing 'volatile' as we make more configuration parameters reconfigurable. Can you check to see whether any of the newly reconfigurable values are consumed within existing locks? If so can we document that and have the reconfiguration of that property get the same lock? > Support reconfiguring namenode replication confs > ------------------------------------------------ > > Key: HDFS-9943 > URL: https://issues.apache.org/jira/browse/HDFS-9943 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Reporter: Tsz Wo Nicholas Sze > Assignee: Xiaobing Zhou > Attachments: HDFS-9943-HDFS-9000.000.patch, HDFS-9943-HDFS-9000.001.patch, HDFS-9943-HDFS-9000.002.patch, HDFS-9943-HDFS-9000.003.patch > > > The following confs should be re-configurable in runtime. > - dfs.namenode.replication.work.multiplier.per.iteration > - dfs.namenode.replication.interval > - dfs.namenode.replication.max-streams > - dfs.namenode.replication.max-streams-hard-limit -- This message was sent by Atlassian JIRA (v6.3.4#6332)