Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 312D819ED2 for ; Wed, 6 Apr 2016 21:55:26 +0000 (UTC) Received: (qmail 12023 invoked by uid 500); 6 Apr 2016 21:55:25 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 11967 invoked by uid 500); 6 Apr 2016 21:55:25 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 11837 invoked by uid 99); 6 Apr 2016 21:55:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Apr 2016 21:55:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 9D5C62C1F62 for ; Wed, 6 Apr 2016 21:55:25 +0000 (UTC) Date: Wed, 6 Apr 2016 21:55:25 +0000 (UTC) From: "Anu Engineer (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-9735) DiskBalancer : Refactor moveBlockAcrossStorage to be used by disk balancer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-9735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229213#comment-15229213 ] Anu Engineer commented on HDFS-9735: ------------------------------------ That is a good question. This is how the current {{FsDatasetSpi#moveBlockAcrossStorage}} works. Since we don't have any bug reports pending against this code , and the fact that a very similar issue was explored in HDFS-9661 make me think that this code is stable. There is a potential that diskbalancer might expose this scenario more than the mover. Are you suggesting that I expand the scope of Synchronized ? [~brahmareddy], [~vinayrpet] & [~arpitagarwal] would guys please care to comment on the question from [~eddyxu]. Thanks in advance. > DiskBalancer : Refactor moveBlockAcrossStorage to be used by disk balancer > -------------------------------------------------------------------------- > > Key: HDFS-9735 > URL: https://issues.apache.org/jira/browse/HDFS-9735 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: balancer & mover > Affects Versions: HDFS-1312 > Reporter: Anu Engineer > Assignee: Anu Engineer > Fix For: HDFS-1312 > > Attachments: HDFS-9735-HDFS-1312.001.patch, HDFS-9735-HDFS-1312.002.patch > > > Refactor moveBlockAcrossStorage so that code can be shared by both mover and diskbalancer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)