Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D5DD51941C for ; Fri, 1 Apr 2016 06:40:26 +0000 (UTC) Received: (qmail 64214 invoked by uid 500); 1 Apr 2016 06:40:26 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 64084 invoked by uid 500); 1 Apr 2016 06:40:26 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 63875 invoked by uid 99); 1 Apr 2016 06:40:26 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Apr 2016 06:40:26 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 9E8022C1F68 for ; Fri, 1 Apr 2016 06:40:25 +0000 (UTC) Date: Fri, 1 Apr 2016 06:40:25 +0000 (UTC) From: "Akira AJISAKA (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-8356) Document missing properties in hdfs-default.xml MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221250#comment-15221250 ] Akira AJISAKA commented on HDFS-8356: ------------------------------------- Thanks [~rchiang] for the update. Review comments for TestHdfsConfigFields.java: {code} // Remove new property for now xmlPropsToSkipCompare.add("dfs.client.hedged.threadpool.size"); {code} 1. Would you remove the above code because HDFS-9886 has been fixed? {code} // Remove support property xmlPropsToSkipCompare .add(DFSConfigKeys.DFS_NAMENODE_MIN_SUPPORTED_DATANODE_VERSION_KEY); xmlPropsToSkipCompare .add(DFSConfigKeys.DFS_DATANODE_MIN_SUPPORTED_NAMENODE_VERSION_KEY); {code} 2. I'm thinking we can remove the above because the parameters don't exist in hdfs-default.xml. {code} configurationPropsToSkipCompare .add(DFSConfigKeys.DFS_DATANODE_MIN_SUPPORTED_NAMENODE_VERSION_KEY); {code} 3. Duplicate. > Document missing properties in hdfs-default.xml > ----------------------------------------------- > > Key: HDFS-8356 > URL: https://issues.apache.org/jira/browse/HDFS-8356 > Project: Hadoop HDFS > Issue Type: Bug > Components: documentation > Affects Versions: 2.7.0 > Reporter: Ray Chiang > Assignee: Ray Chiang > Labels: supportability, test > Attachments: HDFS-8356.001.patch, HDFS-8356.002.patch, HDFS-8356.003.patch, HDFS-8356.004.patch, HDFS-8356.005.patch, HDFS-8356.006.patch, HDFS-8356.007.patch, HDFS-8356.008.patch, HDFS-8356.009.patch, HDFS-8356.010.patch, HDFS-8356.011.patch, HDFS-8356.012.patch > > > The following properties are currently not defined in hdfs-default.xml. These properties should either be > A) documented in hdfs-default.xml OR > B) listed as an exception (with comments, e.g. for internal use) in the TestHdfsConfigFields unit test -- This message was sent by Atlassian JIRA (v6.3.4#6332)