hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Zhuge (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10287) MiniDFSCluster should implement AutoCloseable
Date Mon, 25 Apr 2016 17:06:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256596#comment-15256596
] 

John Zhuge commented on HDFS-10287:
-----------------------------------

Thanks [~boky01] for creating the patch, however, you comment only applies to {{MiniYARNCluster}}
not {{MiniDFSCluster}}. I closed YARN-4959 accordingly. {{MiniDFSCluster}} does NOT extend
any class, thus still has the issue.

BTW, your patch updates unit tests to use "try-with-resources" feature. You should create
a new jira and upload the patch there.

Thank you for looking into the issue!

> MiniDFSCluster should implement AutoCloseable
> ---------------------------------------------
>
>                 Key: HDFS-10287
>                 URL: https://issues.apache.org/jira/browse/HDFS-10287
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 2.7.0
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>            Priority: Trivial
>         Attachments: HDFS-10287.01.patch
>
>
> {{MiniDFSCluster}} should implement {{AutoCloseable}} in order to support [try-with-resources|https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html].
It will make test code a little cleaner and more reliable.
> Since {{AutoCloseable}} is only in Java 1.7 or later, this can not be backported to Hadoop
version prior to 2.7.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message