hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10273) Remove duplicate logSync() and log message in FSN#enterSafemode()
Date Tue, 12 Apr 2016 17:52:25 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237635#comment-15237635
] 

Colin Patrick McCabe commented on HDFS-10273:
---------------------------------------------

+1.  Thanks, [~vinayrpet].

> Remove duplicate logSync() and log message in FSN#enterSafemode()
> -----------------------------------------------------------------
>
>                 Key: HDFS-10273
>                 URL: https://issues.apache.org/jira/browse/HDFS-10273
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.9.0
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>            Priority: Minor
>         Attachments: HDFS-10273-01.patch
>
>
> Remove duplicate logSync() and log message in FSN#enterSafemode()
> {code:title=FSN#enterSafemode(..)}
>       // Before Editlog is in OpenForWrite mode, editLogStream will be null. So,
>       // logSyncAll call can be called only when Edlitlog is in OpenForWrite mode
>       if (isEditlogOpenForWrite) {
>         getEditLog().logSyncAll();
>       }
>       setManualAndResourceLowSafeMode(!resourcesLow, resourcesLow);
>       NameNode.stateChangeLog.info("STATE* Safe mode is ON.\n" +
>           getSafeModeTip());
>       if (isEditlogOpenForWrite) {
>         getEditLog().logSyncAll();
>       }
>       NameNode.stateChangeLog.info("STATE* Safe mode is ON" + getSafeModeTip());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message