hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andras Bokor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10264) Logging improvements in FSImageFormatProtobuf.Saver
Date Mon, 18 Apr 2016 12:53:25 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245601#comment-15245601

Andras Bokor commented on HDFS-10264:

Since the migrating from Log4j/Commons Logging to SLF4J is in progress gradually I suggest
to use the following format:
    LOG.info("Saving image file {} using {}.", newFile, compression);
    LOG.info("Image file {} of size {} bytes saved in {} seconds.", newFile, newFile.length(),
(now() - startTime)/1000);

Also, the type of LOG variable needs to be changed.

What do you think?

> Logging improvements in FSImageFormatProtobuf.Saver
> ---------------------------------------------------
>                 Key: HDFS-10264
>                 URL: https://issues.apache.org/jira/browse/HDFS-10264
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.6.0
>            Reporter: Konstantin Shvachko
>            Assignee: Xiaobing Zhou
>              Labels: newbie
> There are two missing LOG messages in {{FSImageFormat.Saver}} that are missing in {{FSImageFormatProtobuf.Saver}},
which mark start and end of fsimage saving. Would be good to have them logged for protobuf
images as well.

This message was sent by Atlassian JIRA

View raw message