hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10250) Ozone: Add key Persistence
Date Sun, 03 Apr 2016 18:07:25 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223436#comment-15223436
] 

Chris Nauroth commented on HDFS-10250:
--------------------------------------

Hi [~anu].

This look good overall to me.  Thank you!  In addition to the tests included in your patch,
I was able to make a bit more progress with execution of some tests I have for a work-in-progress
patch on end-to-end integration between the REST interface, StorageContainerManager and the
Container Protocol.

I just have one question.  There are a couple of lingering typos in the container protocol
message names: {{ReadKeyResponeProto}}, {{GetKeyResponeProto}}, {{DeleteKeyResponeProto}},
{{ListKeyResponeProto}}, {{WriteChunkReponseProto}} and {{ReadChunkReponseProto}}.  Is this
patch a good time to fix these?  If it's easier to handle a mass rename in a separate refactoring
patch after this one, that's fine too.

> Ozone: Add key Persistence
> --------------------------
>
>                 Key: HDFS-10250
>                 URL: https://issues.apache.org/jira/browse/HDFS-10250
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-10250-HDFS-7240.001.patch
>
>
> Support writing keys to containers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message