hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9895) Push up DataNode#conf to base class
Date Sat, 23 Apr 2016 17:29:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255303#comment-15255303
] 

ASF GitHub Bot commented on HDFS-9895:
--------------------------------------

Github user arp7 commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/92#discussion_r60831863
  
    --- Diff: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DNConf.java
---
    @@ -113,71 +112,71 @@
     
       // Allow LAZY_PERSIST writes from non-local clients?
       private final boolean allowNonLocalLazyPersist;
    -
    +  private final DataNode dn;
       private final int volFailuresTolerated;
       private final int volsConfigured;
     
    -  public DNConf(Configuration conf) {
    -    this.conf = conf;
    -    socketTimeout = conf.getInt(DFS_CLIENT_SOCKET_TIMEOUT_KEY,
    +  public DNConf(final DataNode dn) {
    --- End diff --
    
    The dn.getConf() object is not referenced outside the constructor so you can just pass
a reference to that object. Also DNConf need not keep a reference to the dn. I think you can
just revert all changes to this file.


> Push up DataNode#conf to base class
> -----------------------------------
>
>                 Key: HDFS-9895
>                 URL: https://issues.apache.org/jira/browse/HDFS-9895
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HDFS-9895.000.patch, HDFS-9895.001.patch
>
>
> Since DataNode inherits ReconfigurableBase with Configured as base class where configuration
is maintained, DataNode#conf should be removed for the purpose of brevity.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message