hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anu Engineer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9735) DiskBalancer : Refactor moveBlockAcrossStorage to be used by disk balancer
Date Tue, 05 Apr 2016 19:59:25 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227025#comment-15227025
] 

Anu Engineer commented on HDFS-9735:
------------------------------------

[~eddyxu] Thanks for your code review comments.

bq. We don't need synchronized here, so that it can also be put into the following JDK7 style
try with resource statement.

I did in this way because this was an explicit code change made in HDFS-9661, which moved
away from try with resources statement and added a synchronised. 
Hence I chose to maintain the same syntax.

I will take care of other comments and post a rebased patch soon.



> DiskBalancer : Refactor moveBlockAcrossStorage to be used by disk balancer
> --------------------------------------------------------------------------
>
>                 Key: HDFS-9735
>                 URL: https://issues.apache.org/jira/browse/HDFS-9735
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: balancer & mover
>    Affects Versions: HDFS-1312
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>             Fix For: HDFS-1312
>
>         Attachments: HDFS-9735-HDFS-1312.001.patch
>
>
> Refactor moveBlockAcrossStorage so that code can be shared by both mover and diskbalancer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message