hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9543) DiskBalancer : Add Data mover
Date Sun, 24 Apr 2016 17:27:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255656#comment-15255656
] 

Arpit Agarwal commented on HDFS-9543:
-------------------------------------

Thanks for adding the mover implementation [~anu]. My comments below, all in DiskBalancer.java:
# Line 892: I expect this situation will be seen only if the storage type of a disk has changed
since the planner generated the plan?
# Lie 943: That's a heavyweight lock to hold for the move. I don't think we should synchronize
on the Dataset.
# Line 756: I think computeDelay should substract the time taken for the move else the computed
delay will be too conservative. What do you think?
# Lines 822/823: Precondition.checkState is redundant, subsequent lines will NPE if the either
object is null.
# Line 889: I did not get this TODO. What does it mean to move blocks across block pools?

Minor:
# Line 958: Don't need the logging guards since you are using SLF4J and the parameters are
cheap to generate.
# Should we rename getBlockTolerance to getBlockTolerancePercentage to make it clear its a
percentage and not a fraction?

I will take a look at the tests later.

> DiskBalancer : Add Data mover 
> ------------------------------
>
>                 Key: HDFS-9543
>                 URL: https://issues.apache.org/jira/browse/HDFS-9543
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>         Attachments: HDFS-9543-HDFS-1312.001.patch
>
>
> This patch adds the actual mover logic to the datanode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message