Return-Path: 
 <hdfs-issues-return-155163-apmail-hadoop-hdfs-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id BEFBC1917D
	for <apmail-hadoop-hdfs-issues-archive@minotaur.apache.org>;
 Tue, 15 Mar 2016 08:25:16 +0000 (UTC)
Received: (qmail 46668 invoked by uid 500); 15 Mar 2016 08:20:20 -0000
Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org
Received: (qmail 33024 invoked by uid 500); 15 Mar 2016 08:20:13 -0000
Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:hdfs-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:hdfs-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:hdfs-issues@hadoop.apache.org>
List-Id: <hdfs-issues.hadoop.apache.org>
Reply-To: hdfs-issues@hadoop.apache.org
Delivered-To: mailing list hdfs-issues@hadoop.apache.org
Received: (qmail 28510 invoked by uid 99); 15 Mar 2016 08:16:35 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Mar 2016 08:16:35 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 45C7C2C1F73
	for <hdfs-issues@hadoop.apache.org>; Tue, 15 Mar 2016 08:16:35 +0000 (UTC)
Date: Tue, 15 Mar 2016 08:16:35 +0000 (UTC)
From: "dragon (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12950323.1458029742000.18515.1458029795282@Atlassian.JIRA>
In-Reply-To: <JIRA.12950323.1458029742000@Atlassian.JIRA>
References: <JIRA.12950323.1458029742000@Atlassian.JIRA>
 <JIRA.12950323.1458029742850@arcas>
Subject: [jira] [Created] (HDFS-10059) CLONE - Refactor
 DFSStripedOutputStream and StripedDataStreamer
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394

dragon created HDFS-10059:
-----------------------------

             Summary: CLONE - Refactor DFSStripedOutputStream and StripedDataStreamer
                 Key: HDFS-10059
                 URL: https://issues.apache.org/jira/browse/HDFS-10059
             Project: Hadoop HDFS
          Issue Type: Sub-task
          Components: hdfs-client
            Reporter: dragon
            Assignee: Tsz Wo Nicholas Sze


- DFSStripedOutputStream has a list of StripedDataStreamer(s).  The streamers share a data structure List<BlockingQueue<LocatedBlock>> stripeBlocks for communicate located block and end block information.
For example,
{code}
//StripedDataStreamer.endBlock()
      // before retrieving a new block, transfer the finished block to
      // leading streamer
      LocatedBlock finishedBlock = new LocatedBlock(
          new ExtendedBlock(block.getBlockPoolId(), block.getBlockId(),
              block.getNumBytes(), block.getGenerationStamp()), null);
      try {
        boolean offSuccess = stripedBlocks.get(0).offer(finishedBlock, 30,
            TimeUnit.SECONDS);
{code}
It is unnecessary to create a LocatedBlock object for an end block since the locations passed is null.  Also, the return value is ignored (i.e. offSuccess is not used).

- DFSStripedOutputStream has another data structure cellBuffers for computing parity.  It should be refactored to a class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)