Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AD9E419028 for ; Tue, 15 Mar 2016 08:21:41 +0000 (UTC) Received: (qmail 7743 invoked by uid 500); 15 Mar 2016 08:15:42 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 3161 invoked by uid 500); 15 Mar 2016 08:15:40 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 95273 invoked by uid 99); 15 Mar 2016 08:15:37 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Mar 2016 08:15:37 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 37F6D2C1F58 for ; Tue, 15 Mar 2016 08:15:37 +0000 (UTC) Date: Tue, 15 Mar 2016 08:15:37 +0000 (UTC) From: "dragon (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (HDFS-10038) CLONE - ClientProtocol#createErasureCodingZone API was wrongly annotated as Idempotent MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 dragon created HDFS-10038: ----------------------------- Summary: CLONE - ClientProtocol#createErasureCodingZone API was wrongly annotated as Idempotent Key: HDFS-10038 URL: https://issues.apache.org/jira/browse/HDFS-10038 Project: Hadoop HDFS Issue Type: Sub-task Components: namenode Reporter: dragon Assignee: Vinayakumar B Fix For: HDFS-7285 Currently createErasureCodingZone was annotated as Idempotent But it should be annotated as @AtMostOnce as we handle retries via retryCache. {code} @Idempotent public void createErasureCodingZone(String src, ECSchema schema) throws IOException; {code} It will fail to create Zone if its already a zone. So, simply we can not retry by ignoring previous call success. So, we were using retryCache already for handling this situation. {code} if (getECSchema(srcIIP) != null) { throw new IOException("Directory " + src + " is already in an " + "erasure coding zone."); } {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)