Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Wed, 2 Mar 2016 08:01:18 +0000 (UTC)
From: "Lin Yiqun (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12946030.1456888311000.192052.1456905678106@Atlassian.JIRA>
In-Reply-To: <JIRA.12946030.1456888311000@Atlassian.JIRA>
References: <JIRA.12946030.1456888311000@Atlassian.JIRA>
 <JIRA.12946030.1456888311392@arcas>
Subject: [jira] [Updated] (HDFS-9883) Replace the hard-code value to
 variable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HDFS-9883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lin Yiqun updated HDFS-9883:
----------------------------
    Attachment: HDFS-9883.002.patch

Fixing the checkstyle issues and adding other hard-code palces, attach the latest patch.

> Replace the hard-code value to variable
> ---------------------------------------
>
>                 Key: HDFS-9883
>                 URL: https://issues.apache.org/jira/browse/HDFS-9883
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.7.1
>            Reporter: Lin Yiqun
>            Assignee: Lin Yiqun
>            Priority: Minor
>         Attachments: HDFS-9883.001.patch, HDFS-9883.002.patch
>
>
> In some class of HDFS, there are many hard-code value places. Like this: 
> {code}
>   /** Constructor 
>    * @param bandwidthPerSec bandwidth allowed in bytes per second. 
>    */
>   public DataTransferThrottler(long bandwidthPerSec) {
>     this(500, bandwidthPerSec);  // by default throttling period is 500ms
>   }
> {code}
> It will be better replace these value to variables so that it will not be easily ignored.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)