Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1877D1953D for ; Tue, 1 Mar 2016 23:11:19 +0000 (UTC) Received: (qmail 57508 invoked by uid 500); 1 Mar 2016 23:11:18 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 57428 invoked by uid 500); 1 Mar 2016 23:11:18 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 57059 invoked by uid 99); 1 Mar 2016 23:11:18 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Mar 2016 23:11:18 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 42F342C1F6C for ; Tue, 1 Mar 2016 23:11:18 +0000 (UTC) Date: Tue, 1 Mar 2016 23:11:18 +0000 (UTC) From: "Jing Zhao (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-9876) shouldProcessOverReplicated should not count number of pending replicas MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-9876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-9876: ---------------------------- Attachment: HDFS-9876.001.patch Remove unused internalBlock. > shouldProcessOverReplicated should not count number of pending replicas > ----------------------------------------------------------------------- > > Key: HDFS-9876 > URL: https://issues.apache.org/jira/browse/HDFS-9876 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Takuya Fukudome > Assignee: Jing Zhao > Attachments: HDFS-9876.000.patch, HDFS-9876.001.patch, HDFS-9876.001.patch > > > Currently when checking if we should process over-replicated block in {{addStoredBlock}}, we count both the number of reported replicas and pending replicas. However, {{processOverReplicatedBlock}} chooses excess replicas only among all the reported storages of the block. So in a situation where we have over-replicated replica/internal blocks which only reside in the pending queue, we will not be able to choose any extra replica to delete. > For contiguous blocks, this causes {{chooseExcessReplicasContiguous}} to do nothing. But for striped blocks, this may cause endless loop in {{chooseExcessReplicasStriped}} in the following while loop: > {code} > while (candidates.size() > 1) { > List replicasToDelete = placementPolicy > .chooseReplicasToDelete(nonExcess, candidates, (short) 1, > excessTypes, null, null); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)