Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 61A61189A4 for ; Tue, 15 Mar 2016 06:17:34 +0000 (UTC) Received: (qmail 98017 invoked by uid 500); 15 Mar 2016 06:17:34 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 97949 invoked by uid 500); 15 Mar 2016 06:17:33 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 97685 invoked by uid 99); 15 Mar 2016 06:17:33 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Mar 2016 06:17:33 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 81E922C1F64 for ; Tue, 15 Mar 2016 06:17:33 +0000 (UTC) Date: Tue, 15 Mar 2016 06:17:33 +0000 (UTC) From: "Uma Maheswara Rao G (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-9694) Make existing DFSClient#getFileChecksum() work for striped blocks MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-9694?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D15194= 786#comment-15194786 ]=20 Uma Maheswara Rao G commented on HDFS-9694: ------------------------------------------- [~drankye], Thanks for working on this patch. Great work. Here is my comments/questions # StripedBlockChecksumComputer : Seems like we will actually don=E2=80=99t = do anything with stripes here. We are calculating checksum by block levels = right. So, this should be like StripedBGBlockCheksumComputer/BlockGroupBloc= kChecksumComputer ? So that later When we implement pure stripe based check= sum calculation we could name it as StripedBGStripeCheksumComputer/BlockGro= upStripedChecksumComputer? Just a thought. # StripedFileChecksumComputer : Here also same as above. But I am not stron= g on name at this time but below is my thought, How about StripedFileBlkLev= elChecksumComputer and Later when we compute stripe based computer we name = it as StripedFileStripeLevelChecksumComputer? Just a thought, it will great= if we get more better meaningful naming. # I think client=E2=80=99s getFileCheckSum should have proper java doc whic= h would explain that when we call this API on striped file, it should say t= hat block level checksum would be calculated but not stripe level and check= sum result can=E2=80=99t be compared with replicated file checksum result.= =20 > Make existing DFSClient#getFileChecksum() work for striped blocks > ----------------------------------------------------------------- > > Key: HDFS-9694 > URL: https://issues.apache.org/jira/browse/HDFS-9694 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Kai Zheng > Assignee: Kai Zheng > Attachments: HDFS-9694-v1.patch, HDFS-9694-v2.patch, HDFS-9694-v3= .patch, HDFS-9694-v4.patch, HDFS-9694-v5.patch > > > This is a sub-task of HDFS-8430 and will get the existing API {{FileSyste= m#getFileChecksum(path)}} work for striped files. It will also refactor exi= sting codes and layout basic work for subsequent tasks like support of the = new API proposed there. -- This message was sent by Atlassian JIRA (v6.3.4#6332)