Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Wed, 16 Mar 2016 21:05:33 +0000 (UTC)
From: "Xiao Chen (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12911703.1447111084000.40743.1458162333717@Atlassian.JIRA>
In-Reply-To: <JIRA.12911703.1447111084000@Atlassian.JIRA>
References: <JIRA.12911703.1447111084000@Atlassian.JIRA>
 <JIRA.12911703.1447111084605@arcas>
Subject: [jira] [Commented] (HDFS-9405) When starting a file, NameNode
 should generate EDEK in a separate thread
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198161#comment-15198161 ] 

Xiao Chen commented on HDFS-9405:
---------------------------------

Thanks Andrew. Will address the comments, except:
bq. Do we need this check? The sleep right before it will throw InterruptedException and clear the interrupted status.
The reason for this is to handle {{shutdownNow}} - in which case the runnable will be interrupted. If we happen to be not in {{Thread.sleep}} block, we should exit. right?

bq. It looks like we're trying to ride out KMS downtime, so is there a downside to retrying indefinitely?
I think retrying definitely would be the KISS solution. I feel configuration won't help much for most users.
Retry interval maybe good to be configurable.
Will change into this manner if no objections.

> When starting a file, NameNode should generate EDEK in a separate thread
> ------------------------------------------------------------------------
>
>                 Key: HDFS-9405
>                 URL: https://issues.apache.org/jira/browse/HDFS-9405
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: encryption, namenode
>    Affects Versions: 2.7.1
>            Reporter: Zhe Zhang
>            Assignee: Xiao Chen
>         Attachments: HDFS-9405.01.patch, HDFS-9405.02.patch, HDFS-9405.03.patch, HDFS-9405.04.patch, HDFS-9405.05.patch, HDFS-9405.06.patch, HDFS-9405.07.patch, HDFS-9405.08.patch
>
>
> {{generateEncryptedDataEncryptionKey}} involves a non-trivial I/O operation to the key provider, which could be slow or cause timeout. It should be done as a separate thread so as to return a proper error message to the RPC caller.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)