hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9951) Use string constants for XML tags in OfflineImageReconstructor
Date Mon, 21 Mar 2016 19:38:25 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204956#comment-15204956
] 

Hudson commented on HDFS-9951:
------------------------------

FAILURE: Integrated in Hadoop-trunk-Commit #9483 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/9483/])
HDFS-9951. Use string constants for XML tags in (cmccabe: rev 680716f31e120f4d3ee70b095e4db46c05b891d9)
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageReconstructor.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java


> Use string constants for XML tags in OfflineImageReconstructor
> --------------------------------------------------------------
>
>                 Key: HDFS-9951
>                 URL: https://issues.apache.org/jira/browse/HDFS-9951
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Lin Yiqun
>            Assignee: Lin Yiqun
>            Priority: Minor
>             Fix For: 2.8.0
>
>         Attachments: HDFS-9551.001.patch, HDFS-9551.002.patch, HDFS-9551.003.patch, HDFS-9551.004.patch
>
>
> In class {{OfflineImageReconstructor}}, it uses many {{SectionProcessors}} to process
xml files and load the subtree of the XML into a Node structure. But there are lots of places
that node removes key by directively writing value in methods rather than define them first.
Like this:
> {code}
> Node expiration = directive.removeChild("expiration");
> {code}
> We could improve this to define them in Node and them invoked like this way:
> {code}
> Node expiration=directive.removeChild(Node.CACHE_MANAGER_SECTION_EXPIRATION);
> {code}
> And it will be good to manager node key's name in the future.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message