hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lin Yiqun (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9951) Use string constants for XML tags in OfflineImageReconstructor
Date Fri, 18 Mar 2016 01:47:33 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200798#comment-15200798
] 

Lin Yiqun commented on HDFS-9951:
---------------------------------

I have looked the log, the test {{TestOfflineImageViewer}} was a timed out junit test not
failed. And the jekins log only shows the failed tests reason, like these:
{coed}
Failed tests: 
  TestDataNodeLifeline.testNoLifelineSentIfHeartbeatsOnTime:256 Expect metrics to count no
lifeline calls. expected:<0> but was:<1>

Tests in error: 
  TestHFlush.testHFlushInterrupted ? ClosedByInterrupt

Tests run: 4319, Failures: 1, Errors: 1, Skipped: 17
{code}
And the test for {{TestOfflineImageViewer}} looks good:
{code}
Running org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForXAttr
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.41 sec - in org.apache.hadoop.hdfs.tools.TestDFSAdmin
Running org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerWithStripedBlocks
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.395 sec - in org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForXAttr
Running org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.753 sec - in org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerWithStripedBlocks
Running org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForContentSummary
Running org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl
{code}
Is this means this test was tested ok?

> Use string constants for XML tags in OfflineImageReconstructor
> --------------------------------------------------------------
>
>                 Key: HDFS-9951
>                 URL: https://issues.apache.org/jira/browse/HDFS-9951
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Lin Yiqun
>            Assignee: Lin Yiqun
>            Priority: Minor
>         Attachments: HDFS-9551.001.patch, HDFS-9551.002.patch, HDFS-9551.003.patch
>
>
> In class {{OfflineImageReconstructor}}, it uses many {{SectionProcessors}} to process
xml files and load the subtree of the XML into a Node structure. But there are lots of places
that node removes key by directively writing value in methods rather than define them first.
Like this:
> {code}
> Node expiration = directive.removeChild("expiration");
> {code}
> We could improve this to define them in Node and them invoked like this way:
> {code}
> Node expiration=directive.removeChild(Node.CACHE_MANAGER_SECTION_EXPIRATION);
> {code}
> And it will be good to manager node key's name in the future.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message