hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lin Yiqun (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-9951) Use string constants for XML tags in OfflineImageReconstructor
Date Tue, 15 Mar 2016 05:14:33 GMT

     [ https://issues.apache.org/jira/browse/HDFS-9951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Lin Yiqun updated HDFS-9951:
----------------------------
    Attachment: HDFS-9551.002.patch

Thanks [~cmccabe] for comments. That's right that {{PBImageXmlWriter.java}} should use the
same constants. Update the latest patch for addressing your comments and and fixing checkstyle
issues.

> Use string constants for XML tags in OfflineImageReconstructor
> --------------------------------------------------------------
>
>                 Key: HDFS-9951
>                 URL: https://issues.apache.org/jira/browse/HDFS-9951
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Lin Yiqun
>            Assignee: Lin Yiqun
>            Priority: Minor
>         Attachments: HDFS-9551.001.patch, HDFS-9551.002.patch
>
>
> In class {{OfflineImageReconstructor}}, it uses many {{SectionProcessors}} to process
xml files and load the subtree of the XML into a Node structure. But there are lots of places
that node removes key by directively writing value in methods rather than define them first.
Like this:
> {code}
> Node expiration = directive.removeChild("expiration");
> {code}
> We could improve this to define them in Node and them invoked like this way:
> {code}
> Node expiration=directive.removeChild(Node.CACHE_MANAGER_SECTION_EXPIRATION);
> {code}
> And it will be good to manager node key's name in the future.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message