hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9947) Block#toString should not output information from derived classes
Date Mon, 14 Mar 2016 17:35:33 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193706#comment-15193706
] 

Chris Nauroth commented on HDFS-9947:
-------------------------------------

Regarding the pre-commit -1 for no tests, I'm willing to let it slide.  This is a change in
logging only, the code is unlikely to change often, and the method contract is documented
well.  I'm still +1.

> Block#toString should not output information from derived classes
> -----------------------------------------------------------------
>
>                 Key: HDFS-9947
>                 URL: https://issues.apache.org/jira/browse/HDFS-9947
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.8.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-9947.001.patch
>
>
> {{Block#toString}} should not output information from derived classes.  Thanks for [~cnauroth]
for spotting this bug.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message