hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9941) Do not log StandbyException on NN, other minor logging fixes
Date Fri, 11 Mar 2016 01:16:40 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15190278#comment-15190278
] 

Chris Nauroth commented on HDFS-9941:
-------------------------------------

[~arpitagarwal], thank you for the patch.

{code}
  public void appendUCPartsConcise(StringBuilder sb) {
    sb.append("replicas=");
    int i = 0;
    for (ReplicaUnderConstruction r : replicas) {
      sb.append(r.getExpectedStorageLocation().getDatanodeDescriptor());
      if (++i < replicas.length) {
        sb.append(", ");
      }
    }
    sb.append("");
  }
{code}

The last line looks like a no-op.  Can it be removed?

{code}
    b.<Block>appendStringTo(sb);
{code}

Was the type qualifier here necessary?  It seems like I can compile fine without it.

> Do not log StandbyException on NN, other minor logging fixes
> ------------------------------------------------------------
>
>                 Key: HDFS-9941
>                 URL: https://issues.apache.org/jira/browse/HDFS-9941
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.8.0
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>         Attachments: HDFS-9941.01.patch
>
>
> The NameNode can skip logging StandbyException messages. These are seen regularly in
normal operation and convey no useful information.
> We no longer log the locations of newly allocated blocks in 2.8.0. The DN IDs can be
useful for debugging so let's add that back.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message