hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9941) Do not log StandbyException on NN, other minor logging fixes
Date Fri, 11 Mar 2016 18:43:39 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15191356#comment-15191356

Chris Nauroth commented on HDFS-9941:

The Checkstyle warning is not practical to address in scope of this patch.  The test failures
are unrelated.

While reviewing this, I squinted at the static {{Block#toString}} method for an hour thinking
that I was misunderstanding something about the way Java dynamic dispatch works.  It turns
out no, my understanding is fine, and HDFS-9350 introduced a bug in that method.  This isn't
directly related to the HDFS-9941 patch though, so I left a comment on HDFS-9350 for follow-up.

I am +1 for patch v003 going into trunk, but it doesn't merge cleanly to branch-2.  [~arpitagarwal],
would you please post a patch for branch-2/branch-2.8?  Thank you.

> Do not log StandbyException on NN, other minor logging fixes
> ------------------------------------------------------------
>                 Key: HDFS-9941
>                 URL: https://issues.apache.org/jira/browse/HDFS-9941
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.8.0
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>         Attachments: HDFS-9941.01.patch, HDFS-9941.02.patch, HDFS-9941.03.patch
> The NameNode can skip logging StandbyException messages. These are seen regularly in
normal operation and convey no useful information.
> We no longer log the locations of newly allocated blocks in 2.8.0. The DN IDs can be
useful for debugging so let's add that back.

This message was sent by Atlassian JIRA

View raw message