hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei-Chiu Chuang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9937) Update dfsadmin command line help
Date Fri, 11 Mar 2016 18:13:39 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15191317#comment-15191317
] 

Wei-Chiu Chuang commented on HDFS-9937:
---------------------------------------

Hi, [~lewuathe]
thank you for working on this. The unit test failures seems unrelated to this patch.

The patch looks good to me. In addition to checkstyle and whitespace warnings, just one comment
though.

Could you also update the comment of setSafeMode():

{code:title=DFSAdmin#setSafeMode}
/**
   * Safe mode maintenance command.
   * Usage: hdfs dfsadmin -safemode [enter | leave | get]
   * @param argv List of of command line parameters.
   * @param idx The index of the command that is being processed.
   * @exception IOException if the filesystem does not exist.
   */
  public void setSafeMode(String[] argv, int idx) throws IOException {
{code}

Also I feel pretty bad those help messages are not aligned, but maybe it's OK.

> Update dfsadmin command line help
> ---------------------------------
>
>                 Key: HDFS-9937
>                 URL: https://issues.apache.org/jira/browse/HDFS-9937
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Wei-Chiu Chuang
>            Assignee: Kai Sasaki
>            Priority: Minor
>              Labels: commandline, supportability
>         Attachments: HDFS-9937.01.patch
>
>
> dfsadmin command line top-level help menu is not consistent with detailed help menu.
> * -safemode missed options -wait and -forceExit 
> * -restoreFailedStorage options are not described consistently (true/false/check, or
Set/Unset/Check?)
> * -setSpaceQuota optionally takes a -storageType parameter, but it's not clear what are
the available options. (Seems to be (SSD, DISK, ARCHIVE), from HdfsQuotaAdminGuide.html)
> * -reconfig seems to also take namenode as parameter



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message