hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lin Yiqun (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9919) TestStandbyCheckpoints#testNonPrimarySBNUploadFSImage waitForCheckpoint incorrectly
Date Wed, 09 Mar 2016 01:20:40 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186254#comment-15186254
] 

Lin Yiqun commented on HDFS-9919:
---------------------------------

Thanks [~andrew.wang] for quick review and commit!

> TestStandbyCheckpoints#testNonPrimarySBNUploadFSImage waitForCheckpoint incorrectly
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-9919
>                 URL: https://issues.apache.org/jira/browse/HDFS-9919
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>            Reporter: Lin Yiqun
>            Assignee: Lin Yiqun
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: HDFS-9919.001.patch
>
>
> In HDFS-9787, it sloved the problem that standby NNs can upload FSImage to ANN after
become non-primary standby NN. But in its unit test, it seems there is a small problem. when
ANN change state to standby and standby nns should do a checkpoint. And in test, it makes
a checpoint check as follow:
> {code}
>     for (int i = 0; i < NUM_NNS; i++) {
>       // Once the standby catches up, it should do a checkpoint
>       // and save to local directories.
>       HATestUtil.waitForCheckpoint(cluster, 1, ImmutableList.of(12));
>     }
> {code}
> And in these code, the nnIdx for waitForCheckpoint is always {{1}}, not {{i}}. It seems
there is no need to check one standby nn's checkpoint {{NUM_NNS}} times.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message