hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anu Engineer (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-9891) Ozone: Add container transport client
Date Tue, 08 Mar 2016 01:14:40 GMT

     [ https://issues.apache.org/jira/browse/HDFS-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Anu Engineer updated HDFS-9891:
    Attachment: HDFS-9891-HDFS-7240.002.patch

[~cnauroth] Thanks for the review and your comments.

bq. I tried applying both HDFS-9873 and this one, but it didn't apply cleanly. I assume there
is just some trivial rebase to be done for compatibility with the current revision of the
HDFS-9873 patch.

Thanks, fixed now.

bq. DatanodeID#getContainerPort has a typo in the JavaDocs: "Retruns".

bq. Typically, methods for translating between protobuf objects and our domain objects are
placed into classes in the org.apache.hadoop.hdfs.protocolPB package. Do you think it would
be appropriate to move some of these methods over there, or is there a reason that they need
to stay in DatanodeID and Pipeline?

thanks for pointing it out. I did look at it, but those protocolPB classes where getting huge
, so I decided to change the pattern and break these helper functions into classes of its

bq. XceiverClient#close: Should group.shutdownGracefully() be called before channelFuture.channel().close()?
I believe that means any pending I/O events would be drained first before closing the socket
that event processing depends on.
You are right, thanks for pointing this out. Fixed.

bq. TestContainerServer: There is a risk of resource leaks in these tests. I think this can
be addressed by changing testPipeline to call EmbeddedChannel#close and changing testClientServer
to call XceiverServer#stop and XceiverClient#close. These calls should be guaranteed by using
a finally block.

> Ozone: Add container transport client
> -------------------------------------
>                 Key: HDFS-9891
>                 URL: https://issues.apache.org/jira/browse/HDFS-9891
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>         Attachments: HDFS-9891-HDFS-7240.001.patch, HDFS-9891-HDFS-7240.002.patch
> Add ozone container transport client -- that makes it easy to talk to server.

This message was sent by Atlassian JIRA

View raw message