hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Inigo Goiri (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9882) Add heartbeatsTotal in Datanode metrics
Date Thu, 03 Mar 2016 23:29:18 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178841#comment-15178841
] 

Inigo Goiri commented on HDFS-9882:
-----------------------------------

I think we need to add a description to Metrics.md.
Other than that, I think the patch is good (I don't see any related unit tests for this and
the left checkstyle would break the style of the class).

[~andrew.wang], [~arpitagarwal], do you guys think this is a useful addition?
We found that the heartbeats were reporting as running smoothly but the block report processing
was actually getting stuck because of the disk and delaying the heartbeats which wasn't easy
to monitor. Actually, we are planning to open a separate JIRA to move some of the disk related
checks to a separate thread.

> Add heartbeatsTotal in Datanode metrics
> ---------------------------------------
>
>                 Key: HDFS-9882
>                 URL: https://issues.apache.org/jira/browse/HDFS-9882
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: datanode
>    Affects Versions: 2.7.2
>            Reporter: Hua Liu
>            Assignee: Hua Liu
>            Priority: Minor
>         Attachments: 0001-HDFS-9882.Add-heartbeatsTotal-in-Datanode-metrics.patch, 0002-HDFS-9882.Add-heartbeatsTotal-in-Datanode-metrics.patch
>
>
> Heartbeat latency only reflects the time spent on generating reports and sending reports
to NN. When heartbeats are delayed due to processing commands, this latency does not help
investigation. I would like to propose to add another metric counter to show the total time.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message