hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9876) shouldProcessOverReplicated should not count number of pending replicas
Date Wed, 02 Mar 2016 03:14:18 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174951#comment-15174951

Hudson commented on HDFS-9876:

FAILURE: Integrated in Hadoop-trunk-Commit #9408 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/9408/])
HDFS-9876. shouldProcessOverReplicated should not count number of (jing9: rev f2ba7da4f0df6cf0fc245093aeb4500158e6ee0b)
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

> shouldProcessOverReplicated should not count number of pending replicas
> -----------------------------------------------------------------------
>                 Key: HDFS-9876
>                 URL: https://issues.apache.org/jira/browse/HDFS-9876
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: erasure-coding, namenode
>            Reporter: Takuya Fukudome
>            Assignee: Jing Zhao
>             Fix For: 3.0.0
>         Attachments: HDFS-9876.000.patch, HDFS-9876.001.patch, HDFS-9876.001.patch
> Currently when checking if we should process over-replicated block in {{addStoredBlock}},
we count both the number of reported replicas and pending replicas. However, {{processOverReplicatedBlock}}
chooses excess replicas only among all the reported storages of the block. So in a situation
where we have over-replicated replica/internal blocks which only reside in the pending queue,
we will not be able to choose any extra replica to delete.
> For contiguous blocks, this causes {{chooseExcessReplicasContiguous}} to do nothing.
But for striped blocks, this may cause endless loop in {{chooseExcessReplicasStriped}} in
the following while loop:
> {code}
>       while (candidates.size() > 1) {
>         List<DatanodeStorageInfo> replicasToDelete = placementPolicy
>             .chooseReplicasToDelete(nonExcess, candidates, (short) 1,
>                 excessTypes, null, null);
> {code}

This message was sent by Atlassian JIRA

View raw message