hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9847) HDFS configuration without time unit name should accept friendly time units
Date Fri, 25 Mar 2016 00:51:25 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211227#comment-15211227
] 

Chris Douglas commented on HDFS-9847:
-------------------------------------

bq. Should we just keep the defaults as they are to keep the patch size sane?

Changing the defaults demonstrated that the patch doesn't work. If one were to configure these
variables using units, the test results show that most everything would break.

Since we've spent a lot of time discussing how to change {{Configuration::getTimeDuration}},
we can repurpose this JIRA to commit that consensus. But we can't change the type of a config
variable without updating every instance where it's used. We can accept old values, but calls
that set/get that var as a long are invalid.

For all variables:
{{blah.blah.seconds}}: deprecate, and add a {{blah.blah}} parameter using TimeUnit
{{blah.blah}}: verify that it actually works when configured with units

AFAICT, the deprecation logic in {{Configuration}} should return (and complain) about {{blah.blah.seconds}}
if it's set, and also complain about the missing unit because it should return a long.

bq. still think we should eliminate the warning for branch-2 to avoid overwhelming admins
with benign warnings

I disagree. The warning is not benign, it's informing admins that the type of the var has
changed. If there is code that sets these parameters as longs, the deployment should complain
when it reads so the config (and any related tooling) can be updated.

> HDFS configuration without time unit name should accept friendly time units
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-9847
>                 URL: https://issues.apache.org/jira/browse/HDFS-9847
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 2.7.1
>            Reporter: Lin Yiqun
>            Assignee: Lin Yiqun
>         Attachments: HDFS-9847-branch-2.001.patch, HDFS-9847-branch-2.002.patch, HDFS-9847-nothrow.001.patch,
HDFS-9847-nothrow.002.patch, HDFS-9847.001.patch, HDFS-9847.002.patch, HDFS-9847.003.patch,
HDFS-9847.004.patch, HDFS-9847.005.patch, HDFS-9847.006.patch, branch-2-delta.002.txt, timeduration-w-y.patch
>
>
> In HDFS-9821, it talks about the issue of leting existing keys use friendly units e.g.
60s, 5m, 1d, 6w etc. But there are som configuration key names contain time unit name, like
{{dfs.blockreport.intervalMsec}}, so we can make some other configurations which without time
unit name to accept friendly time units. The time unit  {{seconds}} is frequently used in
hdfs. We can updating this configurations first.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message