hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9847) HDFS configuration without time unit name should accept friendly time units
Date Tue, 15 Mar 2016 16:59:33 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195658#comment-15195658
] 

Arpit Agarwal commented on HDFS-9847:
-------------------------------------

Thank you [~linyiqun]. I don't think we need getLongTimeSeconds and getLongTimeMillis either.
Callers can just use {{getTimeDuration}}. I also suggest adding a getTimeDuration overload
that accepts defaultValue as String so defaults can be defined with units.

e.g. 
{code}
        conf.getTimeDuration(DFSConfigKeys.DFS_HEARTBEAT_INTERVAL_KEY,
            DFSConfigKeys.DFS_HEARTBEAT_INTERVAL_DEFAULT, TimeUnit.SECONDS) // seconds for
backwards compatibility.
{code}

where {{DFS_HEARTBEAT_INTERVAL_DEFAULT = "3s"}}.


> HDFS configuration without time unit name should accept friendly time units
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-9847
>                 URL: https://issues.apache.org/jira/browse/HDFS-9847
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 2.7.1
>            Reporter: Lin Yiqun
>            Assignee: Lin Yiqun
>         Attachments: HDFS-9847.001.patch, HDFS-9847.002.patch, HDFS-9847.003.patch, timeduration-w-y.patch
>
>
> In HDFS-9821, it talks about the issue of leting existing keys use friendly units e.g.
60s, 5m, 1d, 6w etc. But there are som configuration key names contain time unit name, like
{{dfs.blockreport.intervalMsec}}, so we can make some other configurations which without time
unit name to accept friendly time units. The time unit  {{seconds}} is frequently used in
hdfs. We can updating this configurations first.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message