hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-9847) HDFS configuration without time unit name should accept friendly time units
Date Thu, 31 Mar 2016 17:15:25 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220245#comment-15220245
] 

Arpit Agarwal edited comment on HDFS-9847 at 3/31/16 5:14 PM:
--------------------------------------------------------------

Once hdfs-default.xml is updated all existing code that reads the affected parameters is broken
and needs to be fixed (as the failed tests demonstrated). This potentially includes test or
diagnostics code that is not in the Hadoop source tree. So it sounds like changing the defaults
in hdfs-site.xml is incompatible in spirit, even if it does not violate our compatibility
guidelines.

It sounds like the right thing to do is to fix all the code in the Hadoop source tree to read
values with time units (including tests) but leave the defaults as they are for now.


was (Author: arpitagarwal):
bq. We can just update hdfs-default.xml without changing the default values in v003 patch.
Once hdfs-default.xml is updated all existing code that reads the affected parameters is broken
and needs to be fixed (as the failed tests demonstrated). This potentially includes test or
diagnostics code that is not in the Hadoop source tree. So it sounds like changing the defaults
in hdfs-site.xml is incompatible in spirit, even if it does not violate our compatibility
guidelines.

It sounds like the right thing to do is to fix all the code in the Hadoop source tree to read
values with time units (including tests) but leave the defaults as they are for now.

> HDFS configuration without time unit name should accept friendly time units
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-9847
>                 URL: https://issues.apache.org/jira/browse/HDFS-9847
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 2.7.1
>            Reporter: Lin Yiqun
>            Assignee: Lin Yiqun
>         Attachments: HDFS-9847-branch-2.001.patch, HDFS-9847-branch-2.002.patch, HDFS-9847-nothrow.001.patch,
HDFS-9847-nothrow.002.patch, HDFS-9847-nothrow.003.patch, HDFS-9847.001.patch, HDFS-9847.002.patch,
HDFS-9847.003.patch, HDFS-9847.004.patch, HDFS-9847.005.patch, HDFS-9847.006.patch, branch-2-delta.002.txt,
timeduration-w-y.patch
>
>
> In HDFS-9821, it talks about the issue of leting existing keys use friendly units e.g.
60s, 5m, 1d, 6w etc. But there are som configuration key names contain time unit name, like
{{dfs.blockreport.intervalMsec}}, so we can make some other configurations which without time
unit name to accept friendly time units. The time unit  {{seconds}} is frequently used in
hdfs. We can updating this configurations first.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message