hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lei (Eddy) Xu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9835) OIV: add ReverseXML processor which reconstructs an fsimage from an XML file
Date Wed, 02 Mar 2016 00:41:18 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174717#comment-15174717
] 

Lei (Eddy) Xu commented on HDFS-9835:
-------------------------------------

Hi, [~cmccabe]

The patch looks good to me overall.

+1 after addressing final nitpicks:

* There are some checkstyle warnings  for {{switch...case}} indentions. 
* The findbugs warning is false, but can we mitigate it somehow?
* Could you also apply XATTR_..._MASKs to {{PBImageXmlWriter#dumpXAttrs}}. 


Thanks a lot for the work.

> OIV: add ReverseXML processor which reconstructs an fsimage from an XML file
> ----------------------------------------------------------------------------
>
>                 Key: HDFS-9835
>                 URL: https://issues.apache.org/jira/browse/HDFS-9835
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: tools
>    Affects Versions: 2.0.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-9835.001.patch, HDFS-9835.002.patch, HDFS-9835.003.patch, HDFS-9835.004.patch,
HDFS-9835.005.patch
>
>
> OIV: add ReverseXML processor which reconstructs an fsimage from an XML file.  This will
make it easy to create fsimages for testing, and manually edit fsimages when there is corruption.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message