hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anu Engineer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9817) Use SLF4J in new classes
Date Sat, 05 Mar 2016 04:05:40 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15181499#comment-15181499
] 

Anu Engineer commented on HDFS-9817:
------------------------------------

bq. I see you changed log level at several places. Is this on purpose?

Yes, it is on purpose, originally I had them at info level since I was actively developing
and they were useful. Now that code is mostly stable and I took this cleanup opportunity to
reduce the verbosity of logging.

bq. You can merge them in one line, along with some meaningful message.
This is debug log which tells the user which end point it is connecting to and scheme tells
us which connector will be used. I am not sure  I understand what more information I could
provide here.

I can certainly merge them into a single line in a follow up JIRA.

> Use SLF4J in new classes
> ------------------------
>
>                 Key: HDFS-9817
>                 URL: https://issues.apache.org/jira/browse/HDFS-9817
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: logging
>    Affects Versions: HDFS-1312
>            Reporter: Arpit Agarwal
>            Assignee: Anu Engineer
>         Attachments: HDFS-9817-HDFS-1312.001.patch, HDFS-9817-HDFS-1312.002.patch
>
>
> We are trying to use SLF4J for new classes as far as possible so let's change all the
newly added classes to use SLF4J instead of depending on Log4J.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message