hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9732) Remove DelegationTokenIdentifier.toString() —for better logging output
Date Sat, 26 Mar 2016 13:58:25 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213041#comment-15213041
] 

Steve Loughran commented on HDFS-9732:
--------------------------------------

The thing about those logfiles is they are the ones making more use of it, they are the ones
where you only look at them when things have gone wrong and you want as much detail as you
want. There's also the tradition of expanding toString diagnostics in subclasses; here subclasses
would need to know to not call {{super.toString()}} and instead call some other method


Update that and alongside it add a public @stable method {{, say detailsForCLI()}} javadoced
as "do not change this output". A unique name and text will keep anyone from adding it to
it later.

I absolutely do not want to break CLI output here —and I'm glad you picked up on it— all
we need to do know is work out the way to both improve log diagnostics and ensure that nobody
else tries to improve the output later

> Remove DelegationTokenIdentifier.toString() —for better logging output
> ----------------------------------------------------------------------
>
>                 Key: HDFS-9732
>                 URL: https://issues.apache.org/jira/browse/HDFS-9732
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.7.2
>            Reporter: Steve Loughran
>            Assignee: Yongjun Zhang
>         Attachments: HADOOP-12752-001.patch, HDFS-9732.001.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> HDFS {{DelegationTokenIdentifier.toString()}} adds some diagnostics info, owner, sequence
number. But its superclass,  {{AbstractDelegationTokenIdentifier}} contains a lot more information,
including token issue and expiry times.
> Because  {{DelegationTokenIdentifier.toString()}} doesn't include this data,
> information that is potentially useful for kerberos diagnostics is lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message