hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9683) DiskBalancer : Add cancelPlan implementation
Date Thu, 03 Mar 2016 04:52:29 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177167#comment-15177167
] 

Arpit Agarwal commented on HDFS-9683:
-------------------------------------

Hi Anu,
# future cannot be null here, correct?
{code}
  public void cancelPlan(String planID) throws DiskBalancerException {
...
      if ((this.future != null) && (!this.future.isDone())) {
{code}
# We should add a few asserts after the submitPlan and cancelPlan calls in the test cases
to ensure the functions do the right thing.Also,  test cases for canceling a non-existent
plan and canceling when no plan was ever submitted.
# Perhaps in a separate Jira we can also add a test case which uses a mock BlockMover to ensure
that submitPlan and cancelPlan make appropriate calls into the BlockMover.

> DiskBalancer : Add cancelPlan implementation
> --------------------------------------------
>
>                 Key: HDFS-9683
>                 URL: https://issues.apache.org/jira/browse/HDFS-9683
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: balancer & mover
>    Affects Versions: HDFS-1312
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>             Fix For: HDFS-1312
>
>         Attachments: HDFS-9683-HDFS-1312.001.patch
>
>
> Add datanode side code for Cancel Plan



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message