hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mingliang Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9405) When starting a file, NameNode should generate EDEK in a separate thread
Date Thu, 10 Mar 2016 20:15:41 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189869#comment-15189869
] 

Mingliang Liu commented on HDFS-9405:
-------------------------------------

Nits:

0. {{keyNames}} and {{kp}} seem final.
1. I like the idea of retrying. In the code, we log a warning message in each retry. I think
we can downgrade the log level (info or debug) while retrying. We can log a warning message
out of the while loop.
{code}
while (...) {
  try {
    ...
    return;
  } catch (ioe) {
    LOG.debug();
  }
  sleep();
}
LOG.warn();
{code}
2. In the unit test method, is the second spy() needed?

> When starting a file, NameNode should generate EDEK in a separate thread
> ------------------------------------------------------------------------
>
>                 Key: HDFS-9405
>                 URL: https://issues.apache.org/jira/browse/HDFS-9405
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: encryption, namenode
>    Affects Versions: 2.7.1
>            Reporter: Zhe Zhang
>            Assignee: Xiao Chen
>         Attachments: HDFS-9405.01.patch, HDFS-9405.02.patch, HDFS-9405.03.patch
>
>
> {{generateEncryptedDataEncryptionKey}} involves a non-trivial I/O operation to the key
provider, which could be slow or cause timeout. It should be done as a separate thread so
as to return a proper error message to the RPC caller.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message