Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Thu, 18 Feb 2016 21:24:18 +0000 (UTC)
From: "Jing Zhao (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12940205.1455816798000.87052.1455830658160@Atlassian.JIRA>
In-Reply-To: <JIRA.12940205.1455816798000@Atlassian.JIRA>
References: <JIRA.12940205.1455816798000@Atlassian.JIRA>
 <JIRA.12940205.1455816798581@arcas>
Subject: [jira] [Commented] (HDFS-9829) Erasure Coding: Improve few
 exception handling logic of ErasureCodingWorker
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153113#comment-15153113 ] 

Jing Zhao commented on HDFS-9829:
---------------------------------

Thanks for working on this, [~rakeshr]. The patch looks good to me. The only nit is that {{reportCorruptedBlocks}} no longer throws IOException. +1 after addressing it.

> Erasure Coding: Improve few exception handling logic of ErasureCodingWorker
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-9829
>                 URL: https://issues.apache.org/jira/browse/HDFS-9829
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: erasure-coding
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>            Priority: Minor
>         Attachments: HDFS-9829-001.patch
>
>
> # Cancel remaining reads on InterruptedException.
> {code}
> 	} catch (InterruptedException e) {
>           LOG.info("Read data interrupted.", e);
>           break;
>         }
> {code}
> # Shouldn't fail recontruction due to an IOException errors while reporting corrupt blocks.
> {code}
>           } finally {
>             // report corrupted blocks to NN
>             reportCorruptedBlocks(corruptionMap);
>           }
> {code}
> # {{ECW#closeBlockReader()}} function can be simplified using {{IOUtils.closeStream(closable)}}
> # Also, use {} instead of string concatenation in logger.
> {code}
> LOG.debug("Using striped reads; pool threads=" + num);
> //...
> LOG.warn("Found Checksum error for " + reader.block + " from "
>                 + reader.source + " at " + e.getPos());
> //...
> LOG.debug("Using striped block reconstruction; pool threads=" + num);
> //..
> LOG.warn("Failed to reconstruct striped block: " + blockGroup, e);
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)