Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8E5D218032 for ; Fri, 19 Feb 2016 00:35:18 +0000 (UTC) Received: (qmail 73898 invoked by uid 500); 19 Feb 2016 00:35:18 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 73844 invoked by uid 500); 19 Feb 2016 00:35:18 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 73827 invoked by uid 99); 19 Feb 2016 00:35:18 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Feb 2016 00:35:18 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 22ABE2C1F58 for ; Fri, 19 Feb 2016 00:35:18 +0000 (UTC) Date: Fri, 19 Feb 2016 00:35:18 +0000 (UTC) From: "Zhe Zhang (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-9816) Erasure Coding: allow to use multiple EC policies in striping related tests [Part 3] MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-9816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153436#comment-15153436 ] Zhe Zhang commented on HDFS-9816: --------------------------------- bq. Zhe Zhang, regarding your last comment, which test do you mean by testSafeLength? I don't see such a test in TestLeaseRecoveryStriped. Sorry I didn't mention. It is in {{TestBlockRecovery}}. bq. Shall I add a public static method in RecoveryTaskStriped Sounds good. I think we can divide the current {{RecoveryTaskStriped#getSafeLength}} into 2 methods, the second one (starting from {{Arrays.sort(blockLengths)}}) can be made public static. If you can find a good place to put it as an util method that's even better. So to recap, I think we have agreed to 1) keep {{getBlockLengthsSuite}}; 2) create a public static method to calculate safe length in both main and test codes; 3) add hard-coded length numbers for {{TestBlockRecovery#testSafeLength}}. > Erasure Coding: allow to use multiple EC policies in striping related tests [Part 3] > ------------------------------------------------------------------------------------ > > Key: HDFS-9816 > URL: https://issues.apache.org/jira/browse/HDFS-9816 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: erasure-coding, test > Reporter: Rui Li > Assignee: Rui Li > Attachments: HDFS-9816.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)