Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3FBC418239 for ; Fri, 5 Feb 2016 01:07:40 +0000 (UTC) Received: (qmail 77603 invoked by uid 500); 5 Feb 2016 01:07:40 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 77525 invoked by uid 500); 5 Feb 2016 01:07:40 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 77501 invoked by uid 99); 5 Feb 2016 01:07:39 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Feb 2016 01:07:39 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C4C6B2C044E for ; Fri, 5 Feb 2016 01:07:39 +0000 (UTC) Date: Fri, 5 Feb 2016 01:07:39 +0000 (UTC) From: "Kuhu Shukla (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-9762) NetworkTopologyWithNodeGroup.getNodeGroup() can loop infinitely for invalid 'loc' values MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-9762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kuhu Shukla updated HDFS-9762: ------------------------------ Status: Patch Available (was: In Progress) > NetworkTopologyWithNodeGroup.getNodeGroup() can loop infinitely for invalid 'loc' values > ---------------------------------------------------------------------------------------- > > Key: HDFS-9762 > URL: https://issues.apache.org/jira/browse/HDFS-9762 > Project: Hadoop HDFS > Issue Type: Improvement > Affects Versions: 2.7.2 > Reporter: Kuhu Shukla > Assignee: Kuhu Shukla > Priority: Minor > Attachments: HDFS-9762.001.patch > > > Although the DatanodInfo/DataNodeDescriptor object tends to have a non-null, non-empty value for its network location, the getNodeGroup method does not handle the case if an empty or a null value is passed and can go on recursively causing StackOverflowError. This is an improvement to check for such a state and error out if the value is null and set the location to ROOT or empty string and if the original location is empty. -- This message was sent by Atlassian JIRA (v6.3.4#6332)