Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AE8B0185EE for ; Mon, 1 Feb 2016 09:11:44 +0000 (UTC) Received: (qmail 59058 invoked by uid 500); 1 Feb 2016 09:11:40 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 58843 invoked by uid 500); 1 Feb 2016 09:11:40 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 58667 invoked by uid 99); 1 Feb 2016 09:11:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Feb 2016 09:11:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 444F22C1F57 for ; Mon, 1 Feb 2016 09:11:40 +0000 (UTC) Date: Mon, 1 Feb 2016 09:11:40 +0000 (UTC) From: "Hadoop QA (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-9494) Parallel optimization of DFSStripedOutputStream#flushAllInternals( ) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-9494?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D15125= 975#comment-15125975 ]=20 Hadoop QA commented on HDFS-9494: --------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {= color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m= 0s {color} | {color:green} The patch does not contain any @author tags. {c= olor} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green}= 0m 0s {color} | {color:green} The patch appears to include 1 new or modifi= ed test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 23s = {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 8m 57s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m= 33s {color} | {color:green} trunk passed with JDK v1.8.0_66 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m= 4s {color} | {color:green} trunk passed with JDK v1.7.0_91 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 0m 37s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m= 8s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}= 0m 34s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5= m 22s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m= 38s {color} | {color:green} trunk passed with JDK v1.8.0_66 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m= 20s {color} | {color:green} trunk passed with JDK v1.7.0_91 {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 22s = {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 1m 56s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m= 37s {color} | {color:green} the patch passed with JDK v1.8.0_66 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 3= 7s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m= 56s {color} | {color:green} the patch passed with JDK v1.7.0_91 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 5= 6s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 0m 33s {color} | {color:green} hadoop-hdfs-project: patch generated 0 new = + 30 unchanged - 1 fixed =3D 30 total (was 31) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m= 3s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}= 0m 27s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green}= 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5= m 33s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m= 4s {color} | {color:green} the patch passed with JDK v1.8.0_66 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m= 54s {color} | {color:green} the patch passed with JDK v1.7.0_91 {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 13= s {color} | {color:green} hadoop-hdfs-client in the patch passed with JDK v= 1.8.0_66. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 85m 0s {col= or} | {color:red} hadoop-hdfs in the patch failed with JDK v1.8.0_66. {colo= r} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 14= s {color} | {color:green} hadoop-hdfs-client in the patch passed with JDK v= 1.7.0_91. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 121m 17s {c= olor} | {color:red} hadoop-hdfs in the patch failed with JDK v1.7.0_91. {co= lor} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green}= 1m 3s {color} | {color:green} Patch does not generate ASF License warnings= . {color} | | {color:black}{color} | {color:black} {color} | {color:black} 262m 20s {co= lor} | {color:black} {color} | \\ \\ || Reason || Tests || | JDK v1.8.0_66 Failed junit tests | hadoop.hdfs.TestEncryptionZones | | | hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency | | | hadoop.hdfs.security.TestDelegationTokenForProxyUser | | | hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider | | | hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes | | JDK v1.7.0_91 Failed junit tests | hadoop.hdfs.server.datanode.TestDirect= oryScanner | | | hadoop.hdfs.server.namenode.ha.TestHAAppend | | | hadoop.hdfs.security.TestDelegationTokenForProxyUser | | | hadoop.hdfs.server.namenode.TestNamenodeCapacityReport | | | hadoop.hdfs.TestDFSClientRetries | | | hadoop.hdfs.TestDataTransferKeepalive | | JDK v1.7.0_91 Timed out junit tests | org.apache.hadoop.hdfs.TestLeaseRec= overy2 | | | org.apache.hadoop.tools.TestJMXGet | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:0ca8df7 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/1278545= 6/HDFS-9494-origin-trunk.08_testing.patch | | JIRA Issue | HDFS-9494 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsit= e unit findbugs checkstyle | | uname | Linux 69da00262c4f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT We= d Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provide= d.sh | | git revision | trunk / 772ea7b | | Default Java | 1.7.0_91 | | Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/ja= va-7-openjdk-amd64:1.7.0_91 | | findbugs | v3.0.0 | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/14309/artifact/= patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/14309/artifact/= patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HDFS-Build/1430= 9/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0= _66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14309/artifact/p= atchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt | | JDK v1.7.0_91 Test Results | https://builds.apache.org/job/PreCommit-HDF= S-Build/14309/testReport/ | | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-projec= t/hadoop-hdfs U: hadoop-hdfs-project | | Max memory used | 77MB | | Powered by | Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/14309= /console | This message was automatically generated. > Parallel optimization of DFSStripedOutputStream#flushAllInternals( ) > -------------------------------------------------------------------- > > Key: HDFS-9494 > URL: https://issues.apache.org/jira/browse/HDFS-9494 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client > Reporter: GAO Rui > Assignee: GAO Rui > Priority: Minor > Fix For: 3.0.0 > > Attachments: HDFS-9494-origin-trunk.00.patch, HDFS-9494-origin-tr= unk.01.patch, HDFS-9494-origin-trunk.02.patch, HDFS-9494-origin-trunk.03.pa= tch, HDFS-9494-origin-trunk.04.patch, HDFS-9494-origin-trunk.05.patch, HDFS= -9494-origin-trunk.06.patch, HDFS-9494-origin-trunk.07.patch, HDFS-9494-ori= gin-trunk.08.patch, HDFS-9494-origin-trunk.08_testing.patch, HDFS-9494.08.p= atch > > > Currently, in DFSStripedOutputStream#flushAllInternals( ), we trigger and= =20 > wait for flushInternal( ) in sequence. So the runtime flow is like: > {code} > Streamer0#flushInternal( ) > Streamer0#waitForAckedSeqno( ) > Streamer1#flushInternal( ) > Streamer1#waitForAckedSeqno( ) > =E2=80=A6 > Streamer8#flushInternal( ) > Streamer8#waitForAckedSeqno( ) > {code} > It could be better to trigger all the streamers to flushInternal( ) and > wait for all of them to return from waitForAckedSeqno( ), and then flush= AllInternals( ) returns. -- This message was sent by Atlassian JIRA (v6.3.4#6332)