Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 110A618BA3 for ; Wed, 3 Feb 2016 02:15:48 +0000 (UTC) Received: (qmail 321 invoked by uid 500); 3 Feb 2016 02:15:40 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 231 invoked by uid 500); 3 Feb 2016 02:15:40 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 99881 invoked by uid 99); 3 Feb 2016 02:15:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Feb 2016 02:15:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 9A2282C1F6E for ; Wed, 3 Feb 2016 02:15:40 +0000 (UTC) Date: Wed, 3 Feb 2016 02:15:40 +0000 (UTC) From: "Vinayakumar B (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-8999) Allow a file to be closed with COMMITTED but not yet COMPLETE blocks. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129625#comment-15129625 ] Vinayakumar B commented on HDFS-8999: ------------------------------------- Updated the title to be same as CHANGES.txt entry. Also pushed to branch-2.8, which was missed, but CHANGES.txt entry and fix versions were set to 2.8.0 > Allow a file to be closed with COMMITTED but not yet COMPLETE blocks. > --------------------------------------------------------------------- > > Key: HDFS-8999 > URL: https://issues.apache.org/jira/browse/HDFS-8999 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Reporter: Jitendra Nath Pandey > Assignee: Tsz Wo Nicholas Sze > Fix For: 2.8.0 > > Attachments: h8999_20151228.patch, h8999_20160106.patch, h8999_20160106b.patch, h8999_20160106c.patch, h8999_20160111.patch, h8999_20160113.patch, h8999_20160114.patch, h8999_20160121.patch, h8999_20160121b.patch, h8999_20160121c.patch, h8999_20160121c_branch-2.patch, h8999_20160121c_branch-2.patch > > > This comes out of a discussion in HDFS-8763. Pasting [~jingzhao]'s comment from the jira: > {quote} > ...whether we need to let NameNode wait for all the block_received msgs to announce the replica is safe. Looking into the code, now we have > # NameNode knows the DataNodes involved when initially setting up the writing pipeline > # If any DataNode fails during the writing, client bumps the GS and finally reports all the DataNodes included in the new pipeline to NameNode through the updatePipeline RPC. > # When the client received the ack for the last packet of the block (and before the client tries to close the file on NameNode), the replica has been finalized in all the DataNodes. > Then in this case, when NameNode receives the close request from the client, the NameNode already knows the latest replicas for the block. Currently the checkReplication call only counts in all the replicas that NN has already received the block_received msg, but based on the above #2 and #3, it may be safe to also count in all the replicas in the BlockUnderConstructionFeature#replicas? > {quote} -- This message was sent by Atlassian JIRA (v6.3.4#6332)